From: Thierry Reding <thierry.reding@gmail.com>
To: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: Jassi Brar
<jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch] mailbox/tegra-hsp: Use after free in tegra_hsp_remove_doorbells()
Date: Fri, 18 Nov 2016 13:31:53 +0000 [thread overview]
Message-ID: <20161118133153.GB14358@ulmo.ba.sec> (raw)
In-Reply-To: <20161118113410.GC3150@mwanda>
[-- Attachment #1: Type: text/plain, Size: 552 bytes --]
On Fri, Nov 18, 2016 at 02:34:10PM +0300, Dan Carpenter wrote:
> We have to use the _safe version of list_for_each() because we're
> freeing the pointer as we go along. (This might not show up testing
> depending on what config options you have enabled).
>
> Fixes: ed65ee43e397 ("mailbox: Add Tegra HSP driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Good catch! I've applied this on top of the original driver patch that
Jassi acked earlier and I updated the Fixes: line with the new commit
SHA1.
Thanks,
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2016-11-18 13:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 11:34 [patch] mailbox/tegra-hsp: Use after free in tegra_hsp_remove_doorbells() Dan Carpenter
2016-11-18 13:31 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118133153.GB14358@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox