From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [bug report] mlxsw: core: Implement thermal zone
Date: Wed, 23 Nov 2016 22:42:00 +0000 [thread overview]
Message-ID: <20161123224200.GA31108@mwanda> (raw)
Hello Ivan Vecera,
The patch a50c1e35650b: "mlxsw: core: Implement thermal zone" from
Nov 22, 2016, leads to the following static checker warning:
drivers/net/ethernet/mellanox/mlxsw/core_thermal.c:261 mlxsw_thermal_set_trip_temp()
warn: no lower bound on 'temp'
drivers/net/ethernet/mellanox/mlxsw/core_thermal.c
252 static int mlxsw_thermal_set_trip_temp(struct thermal_zone_device *tzdev,
253 int trip, int temp)
254 {
255 struct mlxsw_thermal *thermal = tzdev->devdata;
256
257 if (trip < 0 || trip >= MLXSW_THERMAL_NUM_TRIPS ||
258 temp > MLXSW_THERMAL_MAX_TEMP)
259 return -EINVAL;
260
261 thermal->trips[trip].temp = temp;
Did you allow negative numbers intentionally? It feels like there
should be some kind of min temp.
262 return 0;
263 }
264
regards,
dan carpenter
reply other threads:[~2016-11-23 22:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161123224200.GA31108@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox