From: Dan Carpenter <dan.carpenter@oracle.com>
To: linux-block@vger.kernel.org, Jens Axboe <axboe@fb.com>
Cc: kernel-janitors@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: [patch] swim3: remove some dead code
Date: Thu, 24 Nov 2016 11:34:07 +0000 [thread overview]
Message-ID: <20161124112817.GO17225@mwanda> (raw)
The goto is correct. "rc" is already set to -EBUSY so there is no need
to do anything with that.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c
index c264f2d..59b4a41 100644
--- a/drivers/block/swim3.c
+++ b/drivers/block/swim3.c
@@ -1179,7 +1179,6 @@ static int swim3_add_device(struct macio_dev *mdev, int index)
swim3_err("%s", "Couldn't request interrupt\n");
pmac_call_feature(PMAC_FTR_SWIM3_ENABLE, swim, 0, 0);
goto out_unmap;
- return -EBUSY;
}
init_timer(&fs->timeout);
reply other threads:[~2016-11-24 11:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124112817.GO17225@mwanda \
--to=dan.carpenter@oracle.com \
--cc=axboe@fb.com \
--cc=benh@kernel.crashing.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox