From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shaohua Li <shli@kernel.org>
Date: Mon, 28 Nov 2016 05:37:54 +0000
Subject: Re: [patch] md/r5cache: enable IRQs on error path
Message-Id: <20161128053754.cbppd4ada3oe6klw@kernel.org>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20161124111304.GI17225@mwanda>
In-Reply-To: <20161124111304.GI17225@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Song Liu <songliubraving@fb.com>, linux-raid@vger.kernel.org, kernel-janitors@vger.kernel.org

On Thu, Nov 24, 2016 at 02:13:04PM +0300, Dan Carpenter wrote:
> We need to re-enable the IRQs here before returning.
> 
> Fixes: a39f7afde358 ("md/r5cache: write-out phase and reclaim support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied, thanks!
 
> diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
> index 2a60ce4..6610134 100644
> --- a/drivers/md/raid5-cache.c
> +++ b/drivers/md/raid5-cache.c
> @@ -1029,7 +1029,7 @@ static sector_t r5c_calculate_new_cp(struct r5conf *conf)
>  	spin_lock_irqsave(&log->stripe_in_journal_lock, flags);
>  	if (list_empty(&conf->log->stripe_in_journal_list)) {
>  		/* all stripes flushed */
> -		spin_unlock(&log->stripe_in_journal_lock);
> +		spin_unlock_irqrestore(&log->stripe_in_journal_lock, flags);
>  		return log->next_checkpoint;
>  	}
>  	sh = list_first_entry(&conf->log->stripe_in_journal_list,