kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mike Marshall <hubcap@omnibond.com>
Cc: Martin Brandenburg <martin@omnibond.com>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] orangefs: Axe some dead code
Date: Mon, 28 Nov 2016 11:07:13 +0000	[thread overview]
Message-ID: <20161128110713.GE28558@mwanda> (raw)
In-Reply-To: <CAOg9mSShecnZt56d7pkWHg_WCoge9Ko0=7PSxyfe3r42ukTtXQ@mail.gmail.com>

On Sat, Nov 26, 2016 at 08:51:57AM -0500, Mike Marshall wrote:
> I think I understand what you're saying, except for this part:
> 
> > would have been secretly disapointed at your lack of
> > courage in my heart but it would have been normal and fine.
>
What I'm saying is that for some people the cut off for 4.10 happens
the week or two before 4.9 is released.  I'm sending bugfixes and they
still push them out to 4.11.  It annoys me, secretly.

 
> I'm pretty sure that Linus won't accept a pull request from me
> at the wrong time and that I won't send one at the wrong time
> on purpose.

Linus pulls lots of things that make him unhappy.  If he didn't
compromise he would go mad.

> 
> I've been laboring under the belief that the rc period is when
> we "push only patches that do not include new functionalities",
> and I would have thought that stripping out a few lines of dead
> code would be appropriate then.
> 

No.  -rc is for fixing regressions only.  If it's a fix for a bug that
has *always* been there, then think carefully about how important it is
because that's not a regression fix.  If it's a bug fix, but it's not a
regression fix and it's not critical then wait.  Non-bugfixes should
only go in during the merge window.

regards,
dan carpenter


  reply	other threads:[~2016-11-28 11:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-21 22:17 [PATCH] orangefs: Axe some dead code Christophe JAILLET
2016-11-22 15:49 ` Martin Brandenburg
2016-11-24 12:31   ` Mike Marshall
2016-11-25 21:51     ` Dan Carpenter
2016-11-25 23:09       ` Mike Marshall
2016-11-26 10:02         ` Dan Carpenter
2016-11-26 13:51           ` Mike Marshall
2016-11-28 11:07             ` Dan Carpenter [this message]
2016-11-28 14:06               ` Mike Marshall
2016-11-28 14:36                 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161128110713.GE28558@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=hubcap@omnibond.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin@omnibond.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).