From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Date: Tue, 29 Nov 2016 16:40:04 +0000 Subject: Re: [patch] iommu/amd: Missing error code in amd_iommu_init_device() Message-Id: <20161129164004.GB13850@8bytes.org> List-Id: References: <20161124110544.GE17225@mwanda> In-Reply-To: <20161124110544.GE17225@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: iommu@lists.linux-foundation.org, kernel-janitors@vger.kernel.org On Thu, Nov 24, 2016 at 02:05:44PM +0300, Dan Carpenter wrote: > We should set "ret" to -EINVAL if iommu_group_get() fails. > > Fixes: 55c99a4dc50f ("iommu/amd: Use iommu_attach_group()") > Signed-off-by: Dan Carpenter Applied, thanks.