From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [bug report] Add support of Cavium Liquidio ethernet adapters
Date: Wed, 30 Nov 2016 19:26:21 +0000 [thread overview]
Message-ID: <20161130192621.GL28558@mwanda> (raw)
In-Reply-To: <20161130185754.GA8645@mwanda>
On Wed, Nov 30, 2016 at 07:02:09PM +0000, Vatsavayi, Raghu wrote:
> > 1005 oq_no++) {
> > 1006 if (!(oct->droq_intr & BIT_ULL(oq_no)))
> > 1007 continue;
> > 1008
> > 1009 droq = oct->droq[oq_no];
> > 1010
> > 1011 if (droq->ops.poll_mode) {
> > 1012 droq->ops.napi_fn(droq);
> > 1013 oct_priv->napi_mask |= (1 << oq_no);
> >
> > It should be 1ULL << oq_no. But the other bug is tahte ->napi_mask is a long
> > but that will break on 32 bit systems when
> > MAX_OCTEON_OUTPUT_QUEUES() is 64. Is that a possible combination?
> >
>
> [Raghu]: These drivers are for 64 bit systems as mentioned in Kconfig.
>
Ah... Grand. I see that now. Can you send a patch for the others?
regards,
dan carpenter
prev parent reply other threads:[~2016-11-30 19:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 18:57 [bug report] Add support of Cavium Liquidio ethernet adapters Dan Carpenter
2016-11-30 19:02 ` Vatsavayi, Raghu
2016-11-30 19:26 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161130192621.GL28558@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox