From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Fabian Frederick <fabf@skynet.be>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: ext4: remove another test in ext4_alloc_file_blocks()
Date: Sat, 03 Dec 2016 21:47:58 +0000 [thread overview]
Message-ID: <20161203214758.4jo2dhgjm5ujqzhw@thunk.org> (raw)
In-Reply-To: <20161021095435.GC8271@quack2.suse.cz>
On Fri, Oct 21, 2016 at 11:54:35AM +0200, Jan Kara wrote:
> On Wed 12-10-16 09:00:02, Dan Carpenter wrote:
> > Before commit c3fe493ccdb1 ('ext4: remove unneeded test in
> > ext4_alloc_file_blocks()') then it was possible for "depth" to be -1
> > but now, it's not possible that it is negative.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Looks good. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Applied, thanks.
- Ted
prev parent reply other threads:[~2016-12-03 21:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 6:00 ext4: remove another test in ext4_alloc_file_blocks() Dan Carpenter
2016-10-21 9:54 ` Jan Kara
2016-12-03 21:47 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161203214758.4jo2dhgjm5ujqzhw@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=dan.carpenter@oracle.com \
--cc=fabf@skynet.be \
--cc=jack@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox