From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [bug report] reimplement IDR and IDA using the radix tree
Date: Thu, 08 Dec 2016 12:02:55 +0000 [thread overview]
Message-ID: <20161208120255.GA32427@elgon.mountain> (raw)
In-Reply-To: <20161208115651.GA14667@elgon.mountain>
Hello Matthew Wilcox,
This is a semi-automatic email about new static checker warnings.
The patch 755edccbffa1: "reimplement IDR and IDA using the radix
tree" from Dec 7, 2016, leads to the following Smatch complaint:
lib/radix-tree.c:2413 ida_remove()
warn: variable dereferenced before check 'node' (see line 2409)
lib/radix-tree.c
2408 __clear_bit(offset, bitmap->bitmap);
2409 node_tag_set(&ida->ida_rt, node, IDR_FREE, get_slot_offset(node, slot));
^^^^
Dereference.
2410 if (bitmap_empty(bitmap->bitmap, IDA_BITMAP_BITS)) {
2411 *slot = NULL;
2412 kfree(bitmap);
2413 if (node) {
^^^^
Check.
2414 node->count--;
2415 __radix_tree_delete_node(&ida->ida_rt, node);
regards,
dan carpenter
next prev parent reply other threads:[~2016-12-08 12:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 11:56 [bug report] reimplement IDR and IDA using the radix tree Dan Carpenter
2016-12-08 12:02 ` Dan Carpenter [this message]
2016-12-08 12:25 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208120255.GA32427@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox