From: Dan Carpenter <dan.carpenter@oracle.com>
To: bojan prtvar <prtvar.b@gmail.com>
Cc: "James E.J. Bottomley" <jejb@parisc-linux.org>,
Helge Deller <deller@gmx.de>,
linux-parisc@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] parisc: perf: return -EFAULT on error
Date: Thu, 08 Dec 2016 15:10:15 +0000 [thread overview]
Message-ID: <20161208151014.GW8176@mwanda> (raw)
In-Reply-To: <CAOmT4fTi+7r=1OJsumVC_+ET-NXcGjsZ5+t5ppm0eZZ2VeuF-A@mail.gmail.com>
On Thu, Dec 08, 2016 at 03:53:42PM +0100, bojan prtvar wrote:
> Hi Dan,
>
> On Thu, Dec 8, 2016 at 12:32 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > - if ((err = copy_from_user(&image_type, buf, sizeof(uint32_t))) != 0)
> > - return err;
>
> Why not delete err?
Gar... I'm sorry. I'll resend.
regards,
dan carpenter
next prev parent reply other threads:[~2016-12-08 15:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 11:32 [patch] parisc: perf: return -EFAULT on error Dan Carpenter
2016-12-08 14:53 ` bojan prtvar
2016-12-08 15:10 ` Dan Carpenter [this message]
2016-12-10 9:06 ` [patch v2] " Dan Carpenter
2016-12-10 20:40 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208151014.GW8176@mwanda \
--to=dan.carpenter@oracle.com \
--cc=deller@gmx.de \
--cc=jejb@parisc-linux.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=prtvar.b@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox