From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 08 Dec 2016 15:10:15 +0000 Subject: Re: [patch] parisc: perf: return -EFAULT on error Message-Id: <20161208151014.GW8176@mwanda> List-Id: References: <20161208113200.GC11382@elgon.mountain> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: bojan prtvar Cc: "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, kernel-janitors@vger.kernel.org On Thu, Dec 08, 2016 at 03:53:42PM +0100, bojan prtvar wrote: > Hi Dan, > > On Thu, Dec 8, 2016 at 12:32 PM, Dan Carpenter wrote: > > - if ((err = copy_from_user(&image_type, buf, sizeof(uint32_t))) != 0) > > - return err; > > Why not delete err? Gar... I'm sorry. I'll resend. regards, dan carpenter