* [patch] drm: mxsfb: drm_dev_alloc() returns error pointers
@ 2016-12-13 12:23 Dan Carpenter
2016-12-13 12:36 ` Marek Vasut
2016-12-13 21:25 ` Daniel Vetter
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2016-12-13 12:23 UTC (permalink / raw)
To: Marek Vasut; +Cc: David Airlie, dri-devel, kernel-janitors
We should be checking for IS_ERR() instead of NULL because
drm_dev_alloc() returns error pointers.
Fixes: 45d59d704080 ("drm: Add new driver for MXSFB controller")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index 79a18bf48b54..955441f71500 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -395,8 +395,8 @@ static int mxsfb_probe(struct platform_device *pdev)
pdev->id_entry = of_id->data;
drm = drm_dev_alloc(&mxsfb_driver, &pdev->dev);
- if (!drm)
- return -ENOMEM;
+ if (IS_ERR(drm))
+ return PTR_ERR(drm);
ret = mxsfb_load(drm, 0);
if (ret)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] drm: mxsfb: drm_dev_alloc() returns error pointers
2016-12-13 12:23 [patch] drm: mxsfb: drm_dev_alloc() returns error pointers Dan Carpenter
@ 2016-12-13 12:36 ` Marek Vasut
2016-12-13 21:25 ` Daniel Vetter
1 sibling, 0 replies; 3+ messages in thread
From: Marek Vasut @ 2016-12-13 12:36 UTC (permalink / raw)
To: Dan Carpenter; +Cc: David Airlie, dri-devel, kernel-janitors
On 12/13/2016 01:23 PM, Dan Carpenter wrote:
> We should be checking for IS_ERR() instead of NULL because
> drm_dev_alloc() returns error pointers.
>
> Fixes: 45d59d704080 ("drm: Add new driver for MXSFB controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks,
Reviewed-by: Marek Vasut <marex@denx.de>
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> index 79a18bf48b54..955441f71500 100644
> --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> @@ -395,8 +395,8 @@ static int mxsfb_probe(struct platform_device *pdev)
> pdev->id_entry = of_id->data;
>
> drm = drm_dev_alloc(&mxsfb_driver, &pdev->dev);
> - if (!drm)
> - return -ENOMEM;
> + if (IS_ERR(drm))
> + return PTR_ERR(drm);
>
> ret = mxsfb_load(drm, 0);
> if (ret)
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] drm: mxsfb: drm_dev_alloc() returns error pointers
2016-12-13 12:23 [patch] drm: mxsfb: drm_dev_alloc() returns error pointers Dan Carpenter
2016-12-13 12:36 ` Marek Vasut
@ 2016-12-13 21:25 ` Daniel Vetter
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2016-12-13 21:25 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Marek Vasut, kernel-janitors, dri-devel
On Tue, Dec 13, 2016 at 03:23:32PM +0300, Dan Carpenter wrote:
> We should be checking for IS_ERR() instead of NULL because
> drm_dev_alloc() returns error pointers.
>
> Fixes: 45d59d704080 ("drm: Add new driver for MXSFB controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Queued up in drm-misc for 4.11 (since drm_dev_alloc doesn't fail due to
the small allocs guarantee anyway), will show up in linux-next as soon as
-rc1 hits the door.
Thanks, Daniel
>
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> index 79a18bf48b54..955441f71500 100644
> --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> @@ -395,8 +395,8 @@ static int mxsfb_probe(struct platform_device *pdev)
> pdev->id_entry = of_id->data;
>
> drm = drm_dev_alloc(&mxsfb_driver, &pdev->dev);
> - if (!drm)
> - return -ENOMEM;
> + if (IS_ERR(drm))
> + return PTR_ERR(drm);
>
> ret = mxsfb_load(drm, 0);
> if (ret)
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-13 21:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-13 12:23 [patch] drm: mxsfb: drm_dev_alloc() returns error pointers Dan Carpenter
2016-12-13 12:36 ` Marek Vasut
2016-12-13 21:25 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox