From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] target/iscsi: double free in lio_target_tiqn_addtpg()
Date: Thu, 15 Dec 2016 20:31:28 +0000 [thread overview]
Message-ID: <20161215203127.GA8244@mwanda> (raw)
In-Reply-To: <20161213122703.GB7519@elgon.mountain>
On Thu, Dec 15, 2016 at 04:43:55PM +0100, Bart Van Assche wrote:
> On 12/13/2016 01:27 PM, Dan Carpenter wrote:
> > This iscsit_tpg_add_portal_group() function is only called from
> > lio_target_tiqn_addtpg(). Both functions free the "tpg" pointer on
> > error so it's a double free bug. The memory is allocated in the caller
> > so it should be freed in the caller and not here.
> >
> > Fixes: e48354ce078c ("iscsi-target: Add iSCSI fabric support for target v4.1")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Hello Dan,
>
> Do you think a "Cc: stable" tag should be added to this patch?
>
It will basically only fail for allocation errors. It's probably not
super likely. These are static checker fixes, not something I
encountered in real life.
regards,
dan carpenter
next prev parent reply other threads:[~2016-12-15 20:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 12:27 [patch] target/iscsi: double free in lio_target_tiqn_addtpg() Dan Carpenter
2016-12-13 13:17 ` David Disseldorp
2016-12-15 15:43 ` Bart Van Assche
2016-12-15 20:31 ` Dan Carpenter [this message]
2016-12-16 10:14 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161215203127.GA8244@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox