* [bug report] net: ethernet: ti: davinci_cpdma: add set rate for a channel
@ 2017-01-16 11:24 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2017-01-16 11:24 UTC (permalink / raw)
To: kernel-janitors
Hello Ivan Khoronzhuk,
This is a semi-automatic email about new static checker warnings.
The patch 8f32b90981dc: "net: ethernet: ti: davinci_cpdma: add set
rate for a channel" from Nov 29, 2016, leads to the following Smatch
complaint:
drivers/net/ethernet/ti/davinci_cpdma.c:843 cpdma_chan_set_rate()
warn: variable dereferenced before check 'ch' (see line 838)
drivers/net/ethernet/ti/davinci_cpdma.c
837 {
838 struct cpdma_ctlr *ctlr = ch->ctlr;
^^^^
New NULL check?
839 unsigned long flags, ch_flags;
840 int ret, prio_mode;
841 u32 rmask;
842
843 if (!ch || !is_tx_chan(ch))
^^^
Too late.
844 return -EINVAL;
845
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-01-16 11:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-16 11:24 [bug report] net: ethernet: ti: davinci_cpdma: add set rate for a channel Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox