From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Laura Abbott <labbott@redhat.com>
Cc: kernel-hardening@lists.openwall.com, mark.rutland@arm.com,
f.fainelli@gmail.com, keescook@chromium.org, pawel.moll@arm.com,
ard.biesheuvel@linaro.org, will.deacon@arm.com,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Jinbum Park <jinb.park7@gmail.com>,
vladimir.murzin@arm.com, linux-arm-kernel@lists.infradead.org,
andy.gross@linaro.org, arjan@linux.intel.com, mingo@kernel.org,
paul.gortmaker@windriver.com, jonathan.austin@arm.com
Subject: Re: [kernel-hardening] Re: [PATCH] ARM: mm: add testcases for RODATA
Date: Wed, 18 Jan 2017 23:45:28 +0000 [thread overview]
Message-ID: <20170118234527.GW27312@n2100.armlinux.org.uk> (raw)
In-Reply-To: <46bae2bb-4b4f-158b-6a8d-3737e181ad74@redhat.com>
On Wed, Jan 18, 2017 at 03:38:52PM -0800, Laura Abbott wrote:
> On 01/18/2017 02:36 PM, Russell King - ARM Linux wrote:
> > I don't see why this needs to be in cacheflush.h - it doesn't seem to
> > have anything to do with cache flushing, and placing it in here means
> > that if you change the state of CONFIG_DEBUG_RODATA_TEST, most likely
> > the entire kernel gets rebuilt. Please put it in a separate header
> > file.
>
> cacheflush.h seems to be where all the set_memory_* functions have
> ended up. I was just looking at cleaning that up unless someone
> beats me to it.
+1
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
prev parent reply other threads:[~2017-01-18 23:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 13:53 [PATCH] ARM: mm: add testcases for RODATA Jinbum Park
2017-01-18 14:38 ` Mark Rutland
2017-01-18 19:20 ` Laura Abbott
2017-01-18 21:20 ` Kees Cook
2017-01-18 22:36 ` Russell King - ARM Linux
2017-01-18 23:35 ` Kees Cook
2017-01-18 23:38 ` [kernel-hardening] " Laura Abbott
2017-01-18 23:45 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118234527.GW27312@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andy.gross@linaro.org \
--cc=ard.biesheuvel@linaro.org \
--cc=arjan@linux.intel.com \
--cc=f.fainelli@gmail.com \
--cc=jinb.park7@gmail.com \
--cc=jonathan.austin@arm.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=labbott@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=pawel.moll@arm.com \
--cc=vladimir.murzin@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox