From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Sat, 21 Jan 2017 04:51:43 +0000 Subject: [patch] samples/bpf: silence shift wrapping warning Message-Id: <20170121045143.GC15269@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Arnaldo Carvalho de Melo , Thomas Graf Cc: Alexei Starovoitov , Joe Stringer , "David S. Miller" , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org max_key is a value in the 0-63 range, so on 32 bit systems the shift could wrap. Signed-off-by: Dan Carpenter diff --git a/samples/bpf/lwt_len_hist_user.c b/samples/bpf/lwt_len_hist_user.c index ec8f3bb..bd06eef 100644 --- a/samples/bpf/lwt_len_hist_user.c +++ b/samples/bpf/lwt_len_hist_user.c @@ -68,7 +68,7 @@ int main(int argc, char **argv) for (i = 1; i <= max_key + 1; i++) { stars(starstr, data[i - 1], max_value, MAX_STARS); printf("%8ld -> %-8ld : %-8ld |%-*s|\n", - (1l << i) >> 1, (1l << i) - 1, data[i - 1], + (1ULL << i) >> 1, (1ULL << i) - 1, data[i - 1], MAX_STARS, starstr); }