From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Thumshirn Date: Mon, 23 Jan 2017 09:15:11 +0000 Subject: Re: [PATCH 1/5] blk-throttle: Move three assignments for the variable "ret" in tg_set_max() Message-Id: <20170123091510.GA3517@linux-x5ow.site> List-Id: References: <75495d45-cfc4-9740-39e4-bd4c3e71232b@users.sourceforge.net> In-Reply-To: <75495d45-cfc4-9740-39e4-bd4c3e71232b@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: SF Markus Elfring Cc: linux-block@vger.kernel.org, Jens Axboe , LKML , kernel-janitors@vger.kernel.org On Sun, Jan 22, 2017 at 09:31:29AM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 21 Jan 2017 21:23:06 +0100 >=20 > A local variable was set to an error code before a concrete error situati= on > was detected. Thus move the corresponding assignments into if branches > to indicate a software failure there. >=20 > Signed-off-by: Markus Elfring > --- > block/blk-throttle.c | 23 +++++++++++++---------- > 1 file changed, 13 insertions(+), 10 deletions(-) >=20 > diff --git a/block/blk-throttle.c b/block/blk-throttle.c > index 6f4c96e5f86b..51d112deb02e 100644 > --- a/block/blk-throttle.c > +++ b/block/blk-throttle.c > @@ -1327,27 +1327,30 @@ static ssize_t tg_set_max(struct kernfs_open_file= *of, > break; > ctx.body +=3D len; > =20 > - ret =3D -EINVAL; > p =3D tok; > strsep(&p, "=3D"); > - if (!p || (sscanf(p, "%llu", &val) !=3D 1 && strcmp(p, "max"))) > + if (!p || (sscanf(p, "%llu", &val) !=3D 1 && strcmp(p, "max"))) { > + ret =3D -EINVAL; > goto out_finish; > + } Sorry, I don't like this patch. We know the next error if we encounter one will be EINVAL until we change it. Your patch doesn't introduce a functual change and doesn't improve readability, so I don't really see a point for i= t. Byte, Johannes --=20 Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: Felix Imend=F6rffer, Jane Smithard, Graham Norton HRB 21284 (AG N=FCrnberg) Key fingerprint =3D EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html