Re: [PATCH 2/4] perf probe: Delete an unnecessary assignment in try_to_find_absolute_address()

Masami Hiramatsu
2017-01-23T22:47:46Z

On Mon, 23 Jan 2017 16:24:06 +0100
SF Markus Elfring <elfring@users.sourceforge.net> wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 23 Jan 2017 15:10:19 +0100
>
> Remove an error code assignment which is redundant in an if branch for
> the handling of a memory allocation failure because the same value was set
> for the local variable "err" before.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

This looks good to me :)

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thanks!

> ---
> tools/perf/util/probe-event.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index 6c7508337fe8..5a34c93b818a 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -2956,10 +2956,9 @@ static int try_to_find_absolute_address(struct perf_probe_event *pev,
>
> tev->nargs = pev->nargs;
> tev->args = zalloc(sizeof(struct probe_trace_arg) * tev->nargs);
> - if (!tev->args) {
> - err = -ENOMEM;
> + if (!tev->args)
> goto errout;
> - }
> +
> for (i = 0; i < tev->nargs; i++)
> copy_to_probe_trace_arg(&tev->args[i], &pev->args[i]);
>
> --
> 2.11.0
>

--
Masami Hiramatsu <mhiramat@kernel.org>