From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [patch] tpm: silence an array overflow warning
Date: Mon, 06 Feb 2017 14:15:20 +0000 [thread overview]
Message-ID: <20170206141520.nc7v4u2dysv3lsgj@intel.com> (raw)
In-Reply-To: <20170206092007.GA11103@mwanda>
On Mon, Feb 06, 2017 at 12:20:07PM +0300, Dan Carpenter wrote:
> On Fri, Feb 03, 2017 at 08:11:20PM +0200, Jarkko Sakkinen wrote:
> > On Fri, Feb 03, 2017 at 01:30:40PM +0300, Dan Carpenter wrote:
> > > We should check that we're within bounds first before checking that
> > > "chip->active_banks[i] != TPM2_ALG_ERROR" so I've re-ordered the two
> > > checks.
> > >
> > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > Thank you, good catch! Do you mind if I squash this.
> >
>
> Not at all.
>
> regards,
> dan carpenter
Already went as a separate commit in a pull request to James :-)
/Jarkko
prev parent reply other threads:[~2017-02-06 14:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 10:30 [patch] tpm: silence an array overflow warning Dan Carpenter
2017-02-03 18:11 ` Jarkko Sakkinen
2017-02-06 9:20 ` Dan Carpenter
2017-02-06 14:15 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170206141520.nc7v4u2dysv3lsgj@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox