* [PATCH] scsi: aacraid: rcode is unsigned, so can never be less than zero
@ 2017-02-07 11:27 Colin King
2017-02-07 11:37 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2017-02-07 11:27 UTC (permalink / raw)
To: Adaptec OEM Raid Solutions, James E . J . Bottomley,
Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The check on rcode >= 0 is always true because rcode is unsigned
and can never be less than zero. Remove the redundant check.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/aacraid/aachba.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
index 3b5ddf4..ddfd726 100644
--- a/drivers/scsi/aacraid/aachba.c
+++ b/drivers/scsi/aacraid/aachba.c
@@ -1848,7 +1848,7 @@ int aac_report_phys_luns(struct aac_dev *dev, struct fib *fibptr, int rescan)
FsaNormal, 1, 1, NULL, NULL);
/* analyse data */
- if (rcode >= 0 && phys_luns->resp_flag = 2) {
+ if (phys_luns->resp_flag = 2) {
/* ok and extended reporting */
aac_update_hba_map(dev, phys_luns, rescan);
}
--
2.10.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: aacraid: rcode is unsigned, so can never be less than zero
2017-02-07 11:27 [PATCH] scsi: aacraid: rcode is unsigned, so can never be less than zero Colin King
@ 2017-02-07 11:37 ` Dan Carpenter
2017-02-07 11:37 ` Colin Ian King
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2017-02-07 11:37 UTC (permalink / raw)
To: Colin King
Cc: Adaptec OEM Raid Solutions, James E . J . Bottomley,
Martin K . Petersen, linux-scsi, kernel-janitors, linux-kernel
On Tue, Feb 07, 2017 at 11:27:38AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The check on rcode >= 0 is always true because rcode is unsigned
> and can never be less than zero. Remove the redundant check.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/scsi/aacraid/aachba.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
> index 3b5ddf4..ddfd726 100644
> --- a/drivers/scsi/aacraid/aachba.c
> +++ b/drivers/scsi/aacraid/aachba.c
> @@ -1848,7 +1848,7 @@ int aac_report_phys_luns(struct aac_dev *dev, struct fib *fibptr, int rescan)
> FsaNormal, 1, 1, NULL, NULL);
>
> /* analyse data */
> - if (rcode >= 0 && phys_luns->resp_flag = 2) {
The original code is buggy. rcode should be an int.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: aacraid: rcode is unsigned, so can never be less than zero
2017-02-07 11:37 ` Dan Carpenter
@ 2017-02-07 11:37 ` Colin Ian King
0 siblings, 0 replies; 3+ messages in thread
From: Colin Ian King @ 2017-02-07 11:37 UTC (permalink / raw)
To: Dan Carpenter
Cc: Adaptec OEM Raid Solutions, James E . J . Bottomley,
Martin K . Petersen, linux-scsi, kernel-janitors, linux-kernel
On 07/02/17 11:37, Dan Carpenter wrote:
> On Tue, Feb 07, 2017 at 11:27:38AM +0000, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The check on rcode >= 0 is always true because rcode is unsigned
>> and can never be less than zero. Remove the redundant check.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/scsi/aacraid/aachba.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
>> index 3b5ddf4..ddfd726 100644
>> --- a/drivers/scsi/aacraid/aachba.c
>> +++ b/drivers/scsi/aacraid/aachba.c
>> @@ -1848,7 +1848,7 @@ int aac_report_phys_luns(struct aac_dev *dev, struct fib *fibptr, int rescan)
>> FsaNormal, 1, 1, NULL, NULL);
>>
>> /* analyse data */
>> - if (rcode >= 0 && phys_luns->resp_flag = 2) {
>
> The original code is buggy. rcode should be an int.
Thanks for spotting that. Oops.
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-07 11:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-07 11:27 [PATCH] scsi: aacraid: rcode is unsigned, so can never be less than zero Colin King
2017-02-07 11:37 ` Dan Carpenter
2017-02-07 11:37 ` Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox