From: Leon Romanovsky <leon@kernel.org>
To: SF Markus Elfring
<elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Hal Rosenstock
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Steve Wise <swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 12/14] RDMA/cxgb4: Delete an unnecessary variable initialisation in create_qp()
Date: Thu, 09 Feb 2017 09:02:23 +0000 [thread overview]
Message-ID: <20170209090223.GM6005@mtr-leonro.local> (raw)
In-Reply-To: <b319a50e-9e2a-61c0-5707-b4549b077d6a-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1280 bytes --]
On Wed, Feb 08, 2017 at 10:22:28PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 8 Feb 2017 21:07:07 +0100
>
> The local variable "ret" will be set to an appropriate value a bit later.
> Thus omit the explicit initialisation at the beginning in this function.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/infiniband/hw/cxgb4/qp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c
> index 373d66a511a8..ac63b1f70731 100644
> --- a/drivers/infiniband/hw/cxgb4/qp.c
> +++ b/drivers/infiniband/hw/cxgb4/qp.c
> @@ -202,7 +202,7 @@ static int create_qp(struct c4iw_rdev *rdev, struct t4_wq *wq,
> int wr_len;
> struct c4iw_wr_wait wr_wait;
> struct sk_buff *skb;
> - int ret = 0;
> + int ret;
The more clean approach will be to initialize this variable to -ENOMEM
and remove rest "ret = -ENOMEM" from the function.
> int eqsize;
>
> wq->sq.qid = c4iw_get_qpid(rdev, uctx);
> --
> 2.11.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-02-09 9:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 21:10 [PATCH 00/14] RDMA/cxgb: Fine-tuning for several function implementations SF Markus Elfring
2017-02-08 21:11 ` [PATCH 01/14] RDMA/cxgb3: Use kcalloc() in cxio_create_qp() SF Markus Elfring
2017-02-08 21:12 ` [PATCH 02/14] RDMA/cxgb3: Rename jump labels " SF Markus Elfring
2017-02-08 21:35 ` Andy Shevchenko
[not found] ` <0aff92fa-2891-333a-2e1e-ca309db2ec72-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-02-08 21:13 ` [PATCH 03/14] RDMA/cxgb4: Use kcalloc() in two functions SF Markus Elfring
2017-02-08 21:15 ` [PATCH 05/14] RDMA/cxgb4: Return an error code only as a constant in ep_open() SF Markus Elfring
2017-02-08 21:18 ` [PATCH 08/14] RDMA/cxgb4: Adjust construction of two error messages in recover_lost_dbs() SF Markus Elfring
2017-02-08 21:22 ` [PATCH 12/14] RDMA/cxgb4: Delete an unnecessary variable initialisation in create_qp() SF Markus Elfring
[not found] ` <b319a50e-9e2a-61c0-5707-b4549b077d6a-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-02-09 9:02 ` Leon Romanovsky [this message]
2017-02-08 21:23 ` [PATCH 13/14] RDMA/cxgb4: Rename jump labels in c4iw_create_qp() SF Markus Elfring
2017-02-08 21:24 ` [PATCH 14/14] RDMA/cxgb4: Rename jump labels in rdma_init() SF Markus Elfring
2017-02-08 21:14 ` [PATCH 04/14] RDMA/cxgb4: Use common error handling code in recover_queues() SF Markus Elfring
2017-02-09 9:30 ` Johannes Thumshirn
2017-02-08 21:16 ` [PATCH 06/14] RDMA/cxgb4: Return an error code only as a constant in stag_open() SF Markus Elfring
2017-02-08 21:17 ` [PATCH 07/14] RDMA/cxgb4: Adjust three checks for null pointers SF Markus Elfring
2017-02-08 21:19 ` [PATCH 09/14] RDMA/cxgb4: Use common error handling code in recover_lost_dbs() SF Markus Elfring
2017-02-09 18:57 ` Leon Romanovsky
2017-02-08 21:20 ` [PATCH 10/14] RDMA/cxgb4: Use kmalloc_array() in c4iw_id_table_alloc() SF Markus Elfring
2017-02-08 21:21 ` [PATCH 11/14] RDMA/cxgb4: Use kcalloc() in create_qp() SF Markus Elfring
2017-04-05 18:16 ` [PATCH 00/14] RDMA/cxgb: Fine-tuning for several function implementations Doug Ledford
[not found] ` <1491416174.2923.3.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-04-09 6:30 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170209090223.GM6005@mtr-leonro.local \
--to=leon@kernel.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox