From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [bug report] rhashtable: Add nested tables
Date: Thu, 16 Feb 2017 12:17:03 +0000 [thread overview]
Message-ID: <20170216121703.GA26276@mwanda> (raw)
Hello Herbert Xu,
This is a semi-automatic email about new static checker warnings.
The patch 40137906c5f5: "rhashtable: Add nested tables" from Feb 11,
2017, leads to the following Smatch complaint:
lib/rhashtable.c:149 bucket_table_free()
warn: variable dereferenced before check 'tbl' (see line 146)
lib/rhashtable.c
145 {
146 if (tbl->nest)
^^^^^^^^^
New unchecked dereference.
147 nested_bucket_table_free(tbl);
148
149 if (tbl)
^^^
Old code checked for NULL.
150 kvfree(tbl->locks);
151
regards,
dan carpenter
next reply other threads:[~2017-02-16 12:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 12:17 Dan Carpenter [this message]
2017-02-25 14:38 ` [bug report] rhashtable: Add nested tables Herbert Xu
2017-02-27 2:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170216121703.GA26276@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox