* [PATCH] nvmet-rdma: Fix error handling
@ 2017-02-19 19:04 Christophe JAILLET
2017-02-19 19:46 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Christophe JAILLET @ 2017-02-19 19:04 UTC (permalink / raw)
To: kernel-janitors
According to the surrounding goto, it is likely that 'out_destroy_sq' was
expected here.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/nvme/target/rdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index 60990220bd83..2ae63f7e17ed 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -1091,7 +1091,7 @@ nvmet_rdma_alloc_queue(struct nvmet_rdma_device *ndev,
queue->idx = ida_simple_get(&nvmet_rdma_queue_ida, 0, 0, GFP_KERNEL);
if (queue->idx < 0) {
ret = NVME_RDMA_CM_NO_RSC;
- goto out_free_queue;
+ goto out_destroy_sq;
}
ret = nvmet_rdma_alloc_rsps(queue);
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] nvmet-rdma: Fix error handling
2017-02-19 19:04 [PATCH] nvmet-rdma: Fix error handling Christophe JAILLET
@ 2017-02-19 19:46 ` Christoph Hellwig
2017-02-21 21:20 ` Sagi Grimberg
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2017-02-19 19:46 UTC (permalink / raw)
To: kernel-janitors
On Sun, Feb 19, 2017 at 08:04:38PM +0100, Christophe JAILLET wrote:
> According to the surrounding goto, it is likely that 'out_destroy_sq' was
> expected here.
s/surrounding/preceeding/ ?
But the patch itself looks good, thanks.
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvmet-rdma: Fix error handling
2017-02-19 19:46 ` Christoph Hellwig
@ 2017-02-21 21:20 ` Sagi Grimberg
0 siblings, 0 replies; 3+ messages in thread
From: Sagi Grimberg @ 2017-02-21 21:20 UTC (permalink / raw)
To: kernel-janitors
> On Sun, Feb 19, 2017 at 08:04:38PM +0100, Christophe JAILLET wrote:
>> According to the surrounding goto, it is likely that 'out_destroy_sq' was
>> expected here.
>
> s/surrounding/preceeding/ ?
>
> But the patch itself looks good, thanks.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Picked it up and reworded, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-21 21:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-19 19:04 [PATCH] nvmet-rdma: Fix error handling Christophe JAILLET
2017-02-19 19:46 ` Christoph Hellwig
2017-02-21 21:20 ` Sagi Grimberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox