Re: [patch] ib/rxe: double free on error

Leon Romanovsky
2016-06-18T11:03:30Z

[-- Attachment #1: Type: text/plain, Size: 924 bytes --]

On Sat, Jun 18, 2016 at 02:00:03PM +0300, Dan Carpenter wrote:
> On Sat, Jun 18, 2016 at 01:34:30PM +0300, Leon Romanovsky wrote:
> > drivers/infiniband/hw/rxe/rxe.c | 29 ++++++-----------------------
> > 1 file changed, 6 insertions(+), 23 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/rxe/rxe.c b/drivers/infiniband/hw/rxe/rxe.c
> > index 48c41e00..156a1021 100644
> > --- a/drivers/infiniband/hw/rxe/rxe.c
> > +++ b/drivers/infiniband/hw/rxe/rxe.c
> > @@ -165,42 +165,25 @@ static int rxe_init_port_param(struct rxe_port *port)
> > */
> > static int rxe_init_ports(struct rxe_dev *rxe)
> > {
> > - int err;
> > - struct rxe_port *port;
> > -
> > - port = &rxe->port;
> > + struct rxe_port *port = rxe->port;
>
> This won't compile.

Interesting, it compiled locally. I'll check it now.

>
> Just give me Reported-by credit not authorship.
>
> regards,
> dan carpenter
>

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]