From: Dan Carpenter <dan.carpenter@oracle.com>
To: Brian Austin <brian.austin@cirrus.com>
Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
Takashi Iwai <tiwai@suse.com>,
Paul Handrigan <Paul.Handrigan@cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Subject: [patch] ASoC: cs35l35: returning uninitialized in probe()
Date: Mon, 13 Mar 2017 12:32:37 +0000 [thread overview]
Message-ID: <20170313123237.GA9287@mwanda> (raw)
If cs35l35->pdata.stereo is false then "ret" isn't initialized.
Fixes: 6387f866a2cc ("ASoC: Add support for Cirrus Logic CS35L35 Amplifier")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c
index 260ed42c71e9..142ae642eaa1 100644
--- a/sound/soc/codecs/cs35l35.c
+++ b/sound/soc/codecs/cs35l35.c
@@ -964,7 +964,7 @@ static int cs35l35_codec_probe(struct snd_soc_codec *codec)
}
}
- return ret;
+ return 0;
}
static struct snd_soc_codec_driver soc_codec_dev_cs35l35 = {
next reply other threads:[~2017-03-13 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 12:32 Dan Carpenter [this message]
2017-03-13 14:36 ` [patch] ASoC: cs35l35: returning uninitialized in probe() Paul Handrigan
2017-03-13 16:57 ` Applied "ASoC: cs35l35: returning uninitialized in probe()" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170313123237.GA9287@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=broonie@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox