* [PATCH] x86/microcode/AMD: remove redundant null check on mc
@ 2017-03-15 17:10 Colin King
2017-03-18 9:27 ` Borislav Petkov
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-03-15 17:10 UTC (permalink / raw)
To: Borislav Petkov, Thomas Gleixner, Ingo Molnar, H . Peter Anvin,
x86
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
mc is a pointer to the static u8 array amd_ucode_patch and
therefore can never be null, so the check is redundant. Remove it.
Detected by CoverityScan, CID#1372871 ("Logically Dead Code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
arch/x86/kernel/cpu/microcode/amd.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/x86/kernel/cpu/microcode/amd.c b/arch/x86/kernel/cpu/microcode/amd.c
index 7889ae4..f2afe99 100644
--- a/arch/x86/kernel/cpu/microcode/amd.c
+++ b/arch/x86/kernel/cpu/microcode/amd.c
@@ -352,9 +352,6 @@ void reload_ucode_amd(void)
u32 rev, dummy;
mc = (struct microcode_amd *)amd_ucode_patch;
- if (!mc)
- return;
-
rdmsr(MSR_AMD64_PATCH_LEVEL, rev, dummy);
if (rev < mc->hdr.patch_id) {
--
2.10.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/microcode/AMD: remove redundant null check on mc
2017-03-15 17:10 [PATCH] x86/microcode/AMD: remove redundant null check on mc Colin King
@ 2017-03-18 9:27 ` Borislav Petkov
0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2017-03-18 9:27 UTC (permalink / raw)
To: Colin King
Cc: Thomas Gleixner, Ingo Molnar, H . Peter Anvin, x86,
kernel-janitors, linux-kernel
On Wed, Mar 15, 2017 at 05:10:10PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> mc is a pointer to the static u8 array amd_ucode_patch and
> therefore can never be null, so the check is redundant. Remove it.
>
> Detected by CoverityScan, CID#1372871 ("Logically Dead Code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> arch/x86/kernel/cpu/microcode/amd.c | 3 ---
> 1 file changed, 3 deletions(-)
Applied, thanks.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-18 9:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-15 17:10 [PATCH] x86/microcode/AMD: remove redundant null check on mc Colin King
2017-03-18 9:27 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox