Re: dm crypt: remove an impossible condition

Dan Carpenter
2017-03-18T04:14:22Z

On Fri, Mar 17, 2017 at 05:38:19PM -0400, Mike Snitzer wrote:
> On Fri, Mar 17 2017 at 4:46pm -0400,
> Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> > Static checkers complain that it doesn't make sense to check if "sval"
> > is NULL. The intention was to check if strchr() returned NULL, but in
> > that situation "sval" would be "NULL + 1" so the check doesn't work. We
> > know from the sscanf() that there is a ':' character in the string so
> > the check is unnecessary and can be removed.
> >
> > Now that the check doesn't depend on "sval" it can be moved earlier
> > for readability.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Thanks Dan, I've folded this fix into the original commit, see:
> https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-4.12&idÏ22cd5f3afe7335afee5659f7450000e8fa2a15
>
> I didn't add your Signed-off-by though, I can backfill that if you
> like.. it is just I didn't want to taint you with all the extensive
> changes in that commit.

That's fine, thanks. Sign-off isn't really the appropriate tag anyway...

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html