public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [PATCH] kprobes: Remove an unneeded condition
Date: Tue, 21 Mar 2017 20:43:48 +0000	[thread overview]
Message-ID: <20170321204348.GD22118@mwanda> (raw)

We know that "addr" is non-NULL here so there is no need to check if
"addr + offset" is NULL.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index d733479a10ee..88617178a63e 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -1403,9 +1403,7 @@ static kprobe_opcode_t *_kprobe_addr(kprobe_opcode_t *addr,
 			return ERR_PTR(-ENOENT);
 	}
 
-	addr = (kprobe_opcode_t *)(((char *)addr) + offset);
-	if (addr)
-		return addr;
+	return (kprobe_opcode_t *)(((char *)addr) + offset);
 
 invalid:
 	return ERR_PTR(-EINVAL);

             reply	other threads:[~2017-03-21 20:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21 20:43 Dan Carpenter [this message]
2017-03-21 22:55 ` [PATCH] kprobes: Remove an unneeded condition Masami Hiramatsu
2017-03-22  9:34 ` Dan Carpenter
2017-03-23  0:15 ` Masami Hiramatsu
2017-03-24  9:50   ` [PATCH v2] kprobes: cleanup _kprobe_addr() Dan Carpenter
2017-03-27  2:19     ` Masami Hiramatsu
2017-03-23  9:22 ` [PATCH] kprobes: Remove an unneeded condition Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170321204348.GD22118@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox