From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] kprobes: Remove an unneeded condition
Date: Thu, 23 Mar 2017 09:22:01 +0000 [thread overview]
Message-ID: <20170323092201.GL32449@mwanda> (raw)
In-Reply-To: <20170321204348.GD22118@mwanda>
On Thu, Mar 23, 2017 at 09:15:16AM +0900, Masami Hiramatsu wrote:
> On Wed, 22 Mar 2017 12:34:26 +0300
> Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> > On Wed, Mar 22, 2017 at 07:55:38AM +0900, Masami Hiramatsu wrote:
> > > On Tue, 21 Mar 2017 23:43:48 +0300
> > > Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > >
> > > > We know that "addr" is non-NULL here so there is no need to check if
> > > > "addr + offset" is NULL.
> > >
> > > What about "UINT_MAX - addr + 1 = offset" case on 32bit arch ? :)
> > >
> >
> > I think if that's really possible then we are so screwed that a NULL
> > check won't help?
>
> Fair enough. Even if the addr is not NULL, that could be out of text area.
> Could you add that to patch description, and also clean up the whole
> function? It seems "invalid" label is no more needed.
Sure. I'll resend.
regards,
dan carpenter
prev parent reply other threads:[~2017-03-23 9:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 20:43 [PATCH] kprobes: Remove an unneeded condition Dan Carpenter
2017-03-21 22:55 ` Masami Hiramatsu
2017-03-22 9:34 ` Dan Carpenter
2017-03-23 0:15 ` Masami Hiramatsu
2017-03-24 9:50 ` [PATCH v2] kprobes: cleanup _kprobe_addr() Dan Carpenter
2017-03-27 2:19 ` Masami Hiramatsu
2017-03-23 9:22 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170323092201.GL32449@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox