* [PATCH] block: make nr_iovecs unsigned in bio_alloc_bioset()
@ 2017-03-23 10:24 Dan Carpenter
2017-03-23 14:07 ` Christoph Hellwig
2017-03-23 14:16 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2017-03-23 10:24 UTC (permalink / raw)
To: Jens Axboe
Cc: Ming Lei, Mike Christie, Kent Overstreet, Hannes Reinecke,
Chaitanya Kulkarni, Mike Snitzer, Adrian Hunter, linux-block,
kernel-janitors
There isn't a bug here, but Smatch is not smart enough to know that
"nr_iovecs" can't be negative so it complains about underflows.
Really, it's slightly cleaner to make this parameter unsigned.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/include/linux/bio.h b/include/linux/bio.h
index 8e521194f6fc..4931756d86d9 100644
--- a/include/linux/bio.h
+++ b/include/linux/bio.h
@@ -383,7 +383,7 @@ extern struct bio_set *bioset_create_nobvec(unsigned int, unsigned int);
extern void bioset_free(struct bio_set *);
extern mempool_t *biovec_create_pool(int pool_entries);
-extern struct bio *bio_alloc_bioset(gfp_t, int, struct bio_set *);
+extern struct bio *bio_alloc_bioset(gfp_t, unsigned int, struct bio_set *);
extern void bio_put(struct bio *);
extern void __bio_clone_fast(struct bio *, struct bio *);
diff --git a/block/bio.c b/block/bio.c
index e75878f8b14a..6194a8cf2aab 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -427,7 +427,8 @@ static void punt_bios_to_rescuer(struct bio_set *bs)
* RETURNS:
* Pointer to new bio on success, NULL on failure.
*/
-struct bio *bio_alloc_bioset(gfp_t gfp_mask, int nr_iovecs, struct bio_set *bs)
+struct bio *bio_alloc_bioset(gfp_t gfp_mask, unsigned int nr_iovecs,
+ struct bio_set *bs)
{
gfp_t saved_gfp = gfp_mask;
unsigned front_pad;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] block: make nr_iovecs unsigned in bio_alloc_bioset()
2017-03-23 10:24 [PATCH] block: make nr_iovecs unsigned in bio_alloc_bioset() Dan Carpenter
@ 2017-03-23 14:07 ` Christoph Hellwig
2017-03-23 14:16 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2017-03-23 14:07 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jens Axboe, Ming Lei, Mike Christie, Kent Overstreet,
Hannes Reinecke, Chaitanya Kulkarni, Mike Snitzer, Adrian Hunter,
linux-block, kernel-janitors
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] block: make nr_iovecs unsigned in bio_alloc_bioset()
2017-03-23 10:24 [PATCH] block: make nr_iovecs unsigned in bio_alloc_bioset() Dan Carpenter
2017-03-23 14:07 ` Christoph Hellwig
@ 2017-03-23 14:16 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2017-03-23 14:16 UTC (permalink / raw)
To: Dan Carpenter
Cc: Ming Lei, Mike Christie, Kent Overstreet, Hannes Reinecke,
Chaitanya Kulkarni, Mike Snitzer, Adrian Hunter, linux-block,
kernel-janitors
On 03/23/2017 04:24 AM, Dan Carpenter wrote:
> There isn't a bug here, but Smatch is not smart enough to know that
> "nr_iovecs" can't be negative so it complains about underflows.
> Really, it's slightly cleaner to make this parameter unsigned.
Applied, thanks Dan.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-23 14:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-23 10:24 [PATCH] block: make nr_iovecs unsigned in bio_alloc_bioset() Dan Carpenter
2017-03-23 14:07 ` Christoph Hellwig
2017-03-23 14:16 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox