From: Shaohua Li <shli@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Artur Paszkiewicz <artur.paszkiewicz@intel.com>,
linux-raid@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] raid5-ppl: silence a misleading warning message
Date: Fri, 24 Mar 2017 05:37:56 +0000 [thread overview]
Message-ID: <20170324053756.o6efazfnv7fc6ihj@kernel.org> (raw)
In-Reply-To: <20170321204305.GC22118@mwanda>
On Tue, Mar 21, 2017 at 11:43:05PM +0300, Dan Carpenter wrote:
> The "need_cache_flush" variable is never set to false. When the
> variable is true that means we print a warning message at the end of
> the function.
>
> Fixes: 3418d036c81d ("raid5-ppl: Partial Parity Log write logging implementation")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
applied, thanks!
> diff --git a/drivers/md/raid5-ppl.c b/drivers/md/raid5-ppl.c
> index 27bad3e2d7ce..86ea9addb51a 100644
> --- a/drivers/md/raid5-ppl.c
> +++ b/drivers/md/raid5-ppl.c
> @@ -1070,7 +1070,7 @@ int ppl_init_log(struct r5conf *conf)
> struct mddev *mddev = conf->mddev;
> int ret = 0;
> int i;
> - bool need_cache_flush;
> + bool need_cache_flush = false;
>
> pr_debug("md/raid:%s: enabling distributed Partial Parity Log\n",
> mdname(conf->mddev));
prev parent reply other threads:[~2017-03-24 5:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 20:43 [PATCH] raid5-ppl: silence a misleading warning message Dan Carpenter
2017-03-23 12:00 ` Artur Paszkiewicz
2017-03-24 5:37 ` Shaohua Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324053756.o6efazfnv7fc6ihj@kernel.org \
--to=shli@kernel.org \
--cc=artur.paszkiewicz@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox