Re: [PATCH 1/5] IB/qib: Use kcalloc() in qib_init_iba7322_funcs()

SF Markus Elfring
2017-04-05T14:54:40Z

>> @@ -7324,8 +7324,9 @@ struct qib_devdata *qib_init_iba7322_funcs(struct pci_dev *pdev,
>> actual_cnt -= dd->num_pports;
>>
>> tabsize = actual_cnt;
>> - dd->cspec->msix_entries = kzalloc(tabsize *
>> - sizeof(struct qib_msix_entry), GFP_KERNEL);
>> + dd->cspec->msix_entries = kcalloc(tabsize,
>> + sizeof(*dd->cspec->msix_entries),
>> + GFP_KERNEL);
>
> Are we fine with loosing the zeroing of the entries?

How did you get this concern?

Do you really miss such functionality from the other interface?

Regards,
Markus