From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Date: Mon, 10 Apr 2017 05:41:12 +0000 Subject: Re: [PATCH] cpufreq: imx6q: Fix error handling code Message-Id: <20170410052912.GD4377@vireshk-i7> List-Id: References: <20170409073352.8227-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20170409073352.8227-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christophe JAILLET Cc: rjw@rjwysocki.net, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On 09-04-17, 09:33, Christophe JAILLET wrote: > According to the previous error handling code, it is likely that > 'goto out_free_opp' is expected here in order to avoid a memory leak in > error handling path. > > Signed-off-by: Christophe JAILLET > --- > drivers/cpufreq/imx6q-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c > index 7719b02e04f5..b14117dcfff5 100644 > --- a/drivers/cpufreq/imx6q-cpufreq.c > +++ b/drivers/cpufreq/imx6q-cpufreq.c > @@ -255,7 +255,7 @@ static int imx6q_cpufreq_probe(struct platform_device *pdev) > ret = dev_pm_opp_init_cpufreq_table(cpu_dev, &freq_table); > if (ret) { > dev_err(cpu_dev, "failed to init cpufreq table: %d\n", ret); > - goto put_reg; > + goto out_free_opp; > } > > /* Make imx6_soc_volt array's size same as arm opp number */ Acked-by: Viresh Kumar -- viresh