* [PATCH] lightnvm: pblk-gc: fix an error pointer dereference in init
@ 2017-04-13 19:32 Dan Carpenter
2017-04-13 19:35 ` Matias Bjørling
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2017-04-13 19:32 UTC (permalink / raw)
To: Matias Bjorling, Javier González; +Cc: linux-block, kernel-janitors
These labels are reversed so we could end up dereferencing an error
pointer or leaking.
Fixes: 7f347ba6bb3a ("lightnvm: physical block device (pblk) target")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/lightnvm/pblk-gc.c b/drivers/lightnvm/pblk-gc.c
index 9b147cfd8a41..f173fd4ea947 100644
--- a/drivers/lightnvm/pblk-gc.c
+++ b/drivers/lightnvm/pblk-gc.c
@@ -527,10 +527,10 @@ int pblk_gc_init(struct pblk *pblk)
return 0;
-fail_free_main_kthread:
- kthread_stop(gc->gc_ts);
fail_free_writer_kthread:
kthread_stop(gc->gc_writer_ts);
+fail_free_main_kthread:
+ kthread_stop(gc->gc_ts);
return ret;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] lightnvm: pblk-gc: fix an error pointer dereference in init
2017-04-13 19:32 [PATCH] lightnvm: pblk-gc: fix an error pointer dereference in init Dan Carpenter
@ 2017-04-13 19:35 ` Matias Bjørling
0 siblings, 0 replies; 2+ messages in thread
From: Matias Bjørling @ 2017-04-13 19:35 UTC (permalink / raw)
To: Dan Carpenter, Matias Bjorling, Javier González
Cc: linux-block, kernel-janitors
On 04/13/2017 09:32 PM, Dan Carpenter wrote:
> These labels are reversed so we could end up dereferencing an error
> pointer or leaking.
>
> Fixes: 7f347ba6bb3a ("lightnvm: physical block device (pblk) target")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/lightnvm/pblk-gc.c b/drivers/lightnvm/pblk-gc.c
> index 9b147cfd8a41..f173fd4ea947 100644
> --- a/drivers/lightnvm/pblk-gc.c
> +++ b/drivers/lightnvm/pblk-gc.c
> @@ -527,10 +527,10 @@ int pblk_gc_init(struct pblk *pblk)
>
> return 0;
>
> -fail_free_main_kthread:
> - kthread_stop(gc->gc_ts);
> fail_free_writer_kthread:
> kthread_stop(gc->gc_writer_ts);
> +fail_free_main_kthread:
> + kthread_stop(gc->gc_ts);
>
> return ret;
> }
>
Thanks Dan. I've applied it for 4.12.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-13 19:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-13 19:32 [PATCH] lightnvm: pblk-gc: fix an error pointer dereference in init Dan Carpenter
2017-04-13 19:35 ` Matias Bjørling
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox