* [PATCH] esp6: Fix esp6_gso_segment()
@ 2017-04-18 19:51 Dan Carpenter
2017-04-19 5:24 ` Steffen Klassert
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2017-04-18 19:51 UTC (permalink / raw)
To: kernel-janitors
This NULL test is inverted so the function become a no-op.
Fix: 7862b4058b9f10 ("esp: Add gso handlers for esp4 and esp6")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This is still in Steffen's git tree and not yet in the networking tree.
diff --git a/net/ipv6/esp6_offload.c b/net/ipv6/esp6_offload.c
index 1cceeee7cc33..95f10728abaa 100644
--- a/net/ipv6/esp6_offload.c
+++ b/net/ipv6/esp6_offload.c
@@ -120,7 +120,7 @@ static struct sk_buff *esp6_gso_segment(struct sk_buff *skb,
netdev_features_t esp_features = features;
struct xfrm_offload *xo = xfrm_offload(skb);
- if (xo)
+ if (!xo)
goto out;
seq = xo->seq.low;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] esp6: Fix esp6_gso_segment()
2017-04-18 19:51 [PATCH] esp6: Fix esp6_gso_segment() Dan Carpenter
@ 2017-04-19 5:24 ` Steffen Klassert
0 siblings, 0 replies; 2+ messages in thread
From: Steffen Klassert @ 2017-04-19 5:24 UTC (permalink / raw)
To: kernel-janitors
On Tue, Apr 18, 2017 at 10:51:51PM +0300, Dan Carpenter wrote:
> This NULL test is inverted so the function become a no-op.
>
> Fix: 7862b4058b9f10 ("esp: Add gso handlers for esp4 and esp6")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This is still in Steffen's git tree and not yet in the networking tree.
Same patch was already sent to netdev, so I took that one.
Thanks anyway!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-19 5:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-18 19:51 [PATCH] esp6: Fix esp6_gso_segment() Dan Carpenter
2017-04-19 5:24 ` Steffen Klassert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).