From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Ortiz Date: Wed, 19 Apr 2017 12:52:29 +0000 Subject: Re: [PATCH] NFC: nfcmrvl: double free on error path Message-Id: <20170419125229.GE13724@zurbaran.ger.intel.com> List-Id: References: <20170308052237.GA14542@mwanda> <20170401221117.GD22034@zurbaran.ger.intel.com> <20170419113354.6j7co2yuusdqsubl@mwanda> In-Reply-To: <20170419113354.6j7co2yuusdqsubl@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Vincent Cuissard , linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org On Wed, Apr 19, 2017 at 02:47:34PM +0300, Dan Carpenter wrote: > On Sun, Apr 02, 2017 at 12:11:17AM +0200, Samuel Ortiz wrote: > > Hi Dan, > > > > On Wed, Mar 08, 2017 at 08:22:37AM +0300, Dan Carpenter wrote: > > > The nci_spi_send() function calls kfree_skb(skb) on both error and > > > success so this extra kfree_skb() is a double free. > > > > > > Fixes: caf6e49bf6d0 ("NFC: nfcmrvl: add spi driver") > > > Signed-off-by: Dan Carpenter > > > --- > > > Static analysis. Not tested. > > Applied to nfc-next, thanks. > > > > This is still not showing up in linux-next. I sent a pending pull request containing it. Cheers, Samuel