From: Jens Axboe <axboe@kernel.dk>
To: Colin King <colin.king@canonical.com>
Cc: Paolo Valente <paolo.valente@linaro.org>,
linux-block@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][-next] block, bfq: don't dereference bic before null checking it
Date: Thu, 20 Apr 2017 14:19:44 +0000 [thread overview]
Message-ID: <20170420141944.GB10057@kernel.dk> (raw)
In-Reply-To: <20170420140718.19694-1-colin.king@canonical.com>
On Thu, Apr 20 2017, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The call to bfq_check_ioprio_change will dereference bic, however,
> the null check for bic is after this call. Move the the null
> check on bic to before the call to avoid any potential null
> pointer dereference issues.
Thanks, added.
--
Jens Axboe
prev parent reply other threads:[~2017-04-20 14:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 14:07 [PATCH][-next] block, bfq: don't dereference bic before null checking it Colin King
2017-04-20 14:19 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170420141944.GB10057@kernel.dk \
--to=axboe@kernel.dk \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).