From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Date: Thu, 20 Apr 2017 14:19:44 +0000 Subject: Re: [PATCH][-next] block, bfq: don't dereference bic before null checking it Message-Id: <20170420141944.GB10057@kernel.dk> List-Id: References: <20170420140718.19694-1-colin.king@canonical.com> In-Reply-To: <20170420140718.19694-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Paolo Valente , linux-block@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Thu, Apr 20 2017, Colin King wrote: > From: Colin Ian King > > The call to bfq_check_ioprio_change will dereference bic, however, > the null check for bic is after this call. Move the the null > check on bic to before the call to avoid any potential null > pointer dereference issues. Thanks, added. -- Jens Axboe