From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Westphal Date: Fri, 28 Apr 2017 13:03:14 +0000 Subject: Re: [PATCH] netfilter: x_tables: unlock on error in xt_find_table_lock() Message-Id: <20170428130314.GA26935@breakpoint.cc> List-Id: References: <20170428125756.s4ycoffclspnr4zo@mwanda> In-Reply-To: <20170428125756.s4ycoffclspnr4zo@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Pablo Neira Ayuso , Florian Westphal , Jozsef Kadlecsik , "David S. Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, kernel-janitors@vger.kernel.org Dan Carpenter wrote: > According to my static checker we should unlock here before the return. > That seems reasonable to me as well. Indeed, thanks for the fix! Acked-by: Florian Westphal