public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Guenter Roeck <linux@roeck-us.net>,
	Samuel Mendoza-Jonas <sam@mendozajonas.com>
Cc: Jean Delvare <jdelvare@suse.com>,
	linux-hwmon@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] hwmon: (pmbus) Add missing break statements
Date: Wed, 03 May 2017 19:31:40 +0000	[thread overview]
Message-ID: <20170503193140.zbxcdgda7k3rnr2m@mwanda> (raw)

Static checkers complain about these missing break statements.

Fixes: 6eaaea144dc5 ("hwmon: (pmbus) Add client driver for IR35221")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/hwmon/pmbus/ir35221.c b/drivers/hwmon/pmbus/ir35221.c
index cc7b3b542531..00e4a1e264e2 100644
--- a/drivers/hwmon/pmbus/ir35221.c
+++ b/drivers/hwmon/pmbus/ir35221.c
@@ -129,6 +129,7 @@ static int ir35221_read_word_data(struct i2c_client *client, int page, int reg)
 	case PMBUS_IIN_OC_WARN_LIMIT:
 		ret = pmbus_read_word_data(client, page, reg);
 		ret = ir35221_scale_result(ret, -1, PSC_CURRENT_IN);
+		break;
 	case PMBUS_READ_VIN:
 		ret = pmbus_read_word_data(client, page, PMBUS_READ_VIN);
 		ret = ir35221_scale_result(ret, -5, PSC_VOLTAGE_IN);
@@ -222,6 +223,7 @@ static int ir35221_write_word_data(struct i2c_client *client, int page, int reg,
 	case PMBUS_IIN_OC_WARN_LIMIT:
 		val = ir35221_scale_result(word, 1, PSC_CURRENT_IN);
 		ret = pmbus_write_word_data(client, page, reg, val);
+		break;
 	default:
 		ret = -ENODATA;
 		break;

             reply	other threads:[~2017-05-03 19:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-03 19:31 Dan Carpenter [this message]
2017-05-03 21:57 ` [PATCH] hwmon: (pmbus) Add missing break statements Guenter Roeck
2017-05-04  7:28 ` walter harms
2017-05-04  7:31   ` Dan Carpenter
2017-05-04 13:42     ` Guenter Roeck
2017-05-04 14:36       ` walter harms

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170503193140.zbxcdgda7k3rnr2m@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=jdelvare@suse.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=sam@mendozajonas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox