From: "Pali Rohár" <pali.rohar@gmail.com>
To: Colin King <colin.king@canonical.com>
Cc: Liam Breck <kernel@networkimprov.net>,
"Andrew F . Davis" <afd@ti.com>,
Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: bq27xxx: make bq27xxx_battery_settings static
Date: Thu, 04 May 2017 08:10:53 +0000 [thread overview]
Message-ID: <20170504081053.GF15744@pali> (raw)
In-Reply-To: <20170503104554.23019-1-colin.king@canonical.com>
On Wednesday 03 May 2017 11:45:54 Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function bq27xxx_battery_settings can be made static as it
> does not need to be in global scope.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/power/supply/bq27xxx_battery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
> index 7152370b9d61..06f15da32464 100644
> --- a/drivers/power/supply/bq27xxx_battery.c
> +++ b/drivers/power/supply/bq27xxx_battery.c
> @@ -1251,7 +1251,7 @@ static void bq27xxx_battery_set_config(struct bq27xxx_device_info *di,
> /* assume bq27xxx_battery_update() is called hereafter */
> }
>
> -void bq27xxx_battery_settings(struct bq27xxx_device_info *di)
> +static void bq27xxx_battery_settings(struct bq27xxx_device_info *di)
> {
> struct power_supply_battery_info info = {};
> unsigned int min, max;
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2017-05-04 8:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 10:45 [PATCH] power: supply: bq27xxx: make bq27xxx_battery_settings static Colin King
2017-05-04 8:10 ` Pali Rohár [this message]
2017-05-04 15:24 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170504081053.GF15744@pali \
--to=pali.rohar@gmail.com \
--cc=afd@ti.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@networkimprov.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox