From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?B?Um9ow6Fy?= Date: Thu, 04 May 2017 08:10:53 +0000 Subject: Re: [PATCH] power: supply: bq27xxx: make bq27xxx_battery_settings static Message-Id: <20170504081053.GF15744@pali> List-Id: References: <20170503104554.23019-1-colin.king@canonical.com> In-Reply-To: <20170503104554.23019-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Colin King Cc: Liam Breck , "Andrew F . Davis" , Sebastian Reichel , linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Wednesday 03 May 2017 11:45:54 Colin King wrote: > From: Colin Ian King > > The function bq27xxx_battery_settings can be made static as it > does not need to be in global scope. > > Signed-off-by: Colin Ian King > --- > drivers/power/supply/bq27xxx_battery.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c > index 7152370b9d61..06f15da32464 100644 > --- a/drivers/power/supply/bq27xxx_battery.c > +++ b/drivers/power/supply/bq27xxx_battery.c > @@ -1251,7 +1251,7 @@ static void bq27xxx_battery_set_config(struct bq27xxx_device_info *di, > /* assume bq27xxx_battery_update() is called hereafter */ > } > > -void bq27xxx_battery_settings(struct bq27xxx_device_info *di) > +static void bq27xxx_battery_settings(struct bq27xxx_device_info *di) > { > struct power_supply_battery_info info = {}; > unsigned int min, max; Reviewed-by: Pali Rohár -- Pali Rohár pali.rohar@gmail.com