From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Tue, 09 May 2017 05:50:12 +0000
Subject: Re: sky2: Use seq_putc() in sky2_debug_show()
Message-Id: <20170508225012.508f24c0@xeon-e3>
List-Id: <kernel-janitors.vger.kernel.org>
References: <1f36d45e-3ca9-bfb8-0634-901c42390e2c@users.sourceforge.net>
        <8594c152-68a4-c0c7-b4c6-49c753b0c748@gmx.de>
        <a85959a8-a357-d8e0-d7e9-617e2052aed6@users.sourceforge.net>
In-Reply-To: <a85959a8-a357-d8e0-d7e9-617e2052aed6@users.sourceforge.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Lino Sanfilippo <LinoSanfilippo@gmx.de>, netdev@vger.kernel.org, Mirko Lindner <mlindner@marvell.com>, LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org

On Mon, 8 May 2017 19:42:46 +0200
SF Markus Elfring <elfring@users.sourceforge.net> wrote:

> > Which issue do you mean? I dont see any issue you fix here.  
> 
> Are the run time characteristics a bit nicer for the function “seq_putc”
> in comparison to the function “seq_puts” for printing a single line break here?
> 
> Regards,
> Markus

I would put this in why bother category. seq_puts is correct and this is only
in diagnostic output useful to developer and disabled on most distro kernels