From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Date: Thu, 11 May 2017 16:34:47 +0000 Subject: Re: [PATCH 4/4] vmbus: Adjust five checks for null pointers Message-Id: <20170511093447.7e5b66e4@xeon-e3> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: SF Markus Elfring Cc: devel@linuxdriverproject.org, Haiyang Zhang , "K. Y. Srinivasan" , Stephen Hemminger , kernel-janitors@vger.kernel.org, LKML On Thu, 11 May 2017 18:19:21 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 11 May 2017 17:52:38 +0200 > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > The script “checkpatch.pl” pointed information out like the following. > > Comparison to NULL could be written … > > Thus fix the affected source code places. > > Signed-off-by: Markus Elfring Please don't do these kind of checkpatch "fix ups" on existing code. The comparison with NULL is fine, doing this is just useless churn.