From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Colin King <colin.king@canonical.com>
Cc: Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: nand: make nand_ooblayout_lp_hamming_ops static
Date: Mon, 15 May 2017 20:45:44 +0000 [thread overview]
Message-ID: <20170515224544.221974bc@bbrezillon> (raw)
In-Reply-To: <20170504121100.2709-1-colin.king@canonical.com>
On Thu, 4 May 2017 13:11:00 +0100
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> nand_ooblayout_lp_hamming_ops can be made static as it does not need to be
> in global scope.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to nand/fixes.
Thanks,
Boris
> ---
> drivers/mtd/nand/nand_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index d474378ed810..d3a735012b81 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -202,7 +202,7 @@ static int nand_ooblayout_free_lp_hamming(struct mtd_info *mtd, int section,
> return 0;
> }
>
> -const struct mtd_ooblayout_ops nand_ooblayout_lp_hamming_ops = {
> +static const struct mtd_ooblayout_ops nand_ooblayout_lp_hamming_ops = {
> .ecc = nand_ooblayout_ecc_lp_hamming,
> .free = nand_ooblayout_free_lp_hamming,
> };
prev parent reply other threads:[~2017-05-15 20:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 12:11 [PATCH] mtd: nand: make nand_ooblayout_lp_hamming_ops static Colin King
2017-05-04 14:08 ` Boris Brezillon
2017-05-11 18:35 ` Brian Norris
2017-05-15 20:45 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515224544.221974bc@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=colin.king@canonical.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox