From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Date: Tue, 16 May 2017 13:56:18 +0000 Subject: Re: [PATCH] kvm: nVMX: off by one in vmx_write_pml_buffer() Message-Id: <20170516135617.GB13731@potion> List-Id: References: <20170510194317.uh72h3ez7hnvn62v@mwanda> In-Reply-To: <20170510194317.uh72h3ez7hnvn62v@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Paolo Bonzini , Bandan Das , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, kvm@vger.kernel.org, kernel-janitors@vger.kernel.org 2017-05-10 22:43+0300, Dan Carpenter: > There are PML_ENTITY_NUM elements in the pml_address[] array so the > > should be >= or we write beyond the end of the array when we do: > > pml_address[vmcs12->guest_pml_index--] = gpa; > > Fixes: c5f983f6e845 ("nVMX: Implement emulated Page Modification Logging") > Signed-off-by: Dan Carpenter Applied to kvm/master, thanks. (v1 was deemed better after all.)