From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: sched: fix a use-after-free error on chain on the error exit path
Date: Thu, 18 May 2017 15:31:26 +0000 [thread overview]
Message-ID: <20170518.113126.77172400948863631.davem@davemloft.net> (raw)
In-Reply-To: <20170518140702.6072-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Thu, 18 May 2017 15:07:02 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Set chain to null after the call to tcf_chain_destroy so that we don't
> call tcf_chain_put on the error exit path, thus avoiding a use-after-free
> error.
>
> Detected by CoverityScan, CID#1436357 ("Use after free")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Colin, you really need to make some adjustments to how you are submitting
these kinds of patches.
First of all, you must indicate the target tree in your Subject line
as "[PATCH net-next] " in this case.
Also, you need to add an appropriate Fixes: tag right before your
signoff.
Thank you.
next prev parent reply other threads:[~2017-05-18 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 14:07 [PATCH] net: sched: fix a use-after-free error on chain on the error exit path Colin King
2017-05-18 15:31 ` David Miller [this message]
2017-05-19 17:17 ` Cong Wang
2017-05-20 7:13 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518.113126.77172400948863631.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=colin.king@canonical.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox