[PATCH] dmaengine: remove redundant null check on req

Colin King
2017-05-17T13:35:49Z

From: Colin Ian King <colin.king@canonical.com>

Req is never null on at the point of the null check, so
remove this redundant check and just return &req->tx.

Detected by CoverityScan, CID#1436147 ("Logically dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/dma/bcm-sba-raid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c
index 7daa883eeded..8246c26eabe5 100644
--- a/drivers/dma/bcm-sba-raid.c
+++ b/drivers/dma/bcm-sba-raid.c
@@ -582,7 +582,7 @@ sba_prep_dma_interrupt(struct dma_chan *dchan, unsigned long flags)
req->tx.flags = flags;
req->tx.cookie = -EBUSY;

- return (req) ? &req->tx : NULL;
+ return &req->tx;
}

static void sba_fillup_memcpy_msg(struct sba_request *req,
--
2.11.0