* [PATCH] rtlwifi: btcoex: 23b 1ant: fix halbtc8723b1ant_action_wifi_only()
@ 2017-05-20 5:33 Dan Carpenter
2017-05-20 15:01 ` Larry Finger
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2017-05-20 5:33 UTC (permalink / raw)
To: Larry Finger
Cc: Chaoming Li, Kalle Valo, Ping-Ke Shih, Yan-Hsuan Chuang,
linux-wireless, kernel-janitors
The parameters are in the wrong order when we call
halbtc8723b1ant_set_ant_path() so it's equivalent of calling:
halbtc8723b1ant_set_ant_path(btcoexist, BTC_ANT_PATH_WIFI, false, true);
Fixes: f66509e3d7c2 ("rtlwifi: btcoex: Remove 23b 1ant configuration parameter")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c
index f3704d7db4d5..2a7a6ec525a2 100644
--- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c
+++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c
@@ -1429,7 +1429,7 @@ static void halbtc8723b1ant_action_wifi_only(struct btc_coexist *btcoexist)
{
halbtc8723b1ant_coex_table_with_type(btcoexist, FORCE_EXEC, 0);
halbtc8723b1ant_ps_tdma(btcoexist, FORCE_EXEC, false, 8);
- halbtc8723b1ant_set_ant_path(btcoexist, false, false, BTC_ANT_PATH_PTA);
+ halbtc8723b1ant_set_ant_path(btcoexist, BTC_ANT_PATH_PTA, false, false);
}
/* check if BT is disabled */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix halbtc8723b1ant_action_wifi_only()
2017-05-20 5:33 [PATCH] rtlwifi: btcoex: 23b 1ant: fix halbtc8723b1ant_action_wifi_only() Dan Carpenter
@ 2017-05-20 15:01 ` Larry Finger
0 siblings, 0 replies; 2+ messages in thread
From: Larry Finger @ 2017-05-20 15:01 UTC (permalink / raw)
To: Dan Carpenter
Cc: Chaoming Li, Kalle Valo, Ping-Ke Shih, Yan-Hsuan Chuang,
linux-wireless, kernel-janitors
On 05/20/2017 12:33 AM, Dan Carpenter wrote:
> The parameters are in the wrong order when we call
> halbtc8723b1ant_set_ant_path() so it's equivalent of calling:
>
> halbtc8723b1ant_set_ant_path(btcoexist, BTC_ANT_PATH_WIFI, false, true);
>
> Fixes: f66509e3d7c2 ("rtlwifi: btcoex: Remove 23b 1ant configuration parameter")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Now I know why I did not see the Sparse error. This problem was fixed in
https://patchwork.kernel.org/patch/9737583/, which is waiting to be merged. Once
that one is merged, this patch will no longer apply.
NACK.
Larry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-20 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-20 5:33 [PATCH] rtlwifi: btcoex: 23b 1ant: fix halbtc8723b1ant_action_wifi_only() Dan Carpenter
2017-05-20 15:01 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox