Re: [PATCH 0/7] kernel-trace: Fine-tuning for seven function implementations

Steven Rostedt
2017-05-05T21:06:07Z

On Fri, 5 May 2017 23:00:41 +0200
SF Markus Elfring <elfring@users.sourceforge.net> wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 5 May 2017 22:50:05 +0200
>
> A few update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (7):

Hi Markus,

Just to let you know, it's never a good idea to send new patches out
during the merge window. They are most likely to be missed and
forgotten during this time. Unless they are critical bug fixes, it's
best to wait till after a merge window.

I wont be touching or even looking at these until after 4.12-rc1 is
released. Feel free to reply to this email with a ping in a week or two.

Thanks,

-- Steve

> Combine two function calls into one in hist_trigger_entry_print()
> Replace five seq_puts() calls by seq_putc()
> Adjust two checks for null pointers in compatible_field()
> Improve a size determination in create_hist_field()
> Replace two seq_printf() calls by seq_puts() in probes_seq_show()
> Adjust two checks for null pointers in uprobe_buffer_init()
> Delete an error message for a failed memory allocation in create_trace_uprobe()
>
> kernel/trace/trace_events_hist.c | 18 ++++++++----------
> kernel/trace/trace_uprobe.c | 10 ++++------
> 2 files changed, 12 insertions(+), 16 deletions(-)
>